Fix type hint of Field.default to be compatible with Python 3.8 and 3.9
#10972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
1fb04ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73a3bb43.pydantic-docs.pages.dev |
| Branch Preview URL: | https://ellipsis-compat.pydantic-docs.pages.dev |
36 tasks
CodSpeed Performance ReportMerging #10972 will improve performances by 5.55%Comparing Summary
Benchmarks breakdown
|
Coverage report
This PR does not seem to contain any modification to coverable code. |
… 3.9 For Python < 3.10, we define `EllipsisType = type(Ellipsis)` in `_typing_extra`. `EllipsisType` is then used in a type expression but pyright raises an error because `EllipsisType` is defined as variable. Instead, we make use of the `ellipsis` builtin, only available for type checkers (defined in typeshed) as a compatibility hack.
3b9ac56 to
1fb04ac
Compare
sydney-runkle
pushed a commit
that referenced
this pull request
Nov 26, 2024
… 3.9 (#10972) For Python < 3.10, we define `EllipsisType = type(Ellipsis)` in `_typing_extra`. `EllipsisType` is then used in a type expression but pyright raises an error because `EllipsisType` is defined as variable. Instead, we make use of the `ellipsis` builtin, only available for type checkers (defined in typeshed) as a compatibility hack.
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10971.
For Python < 3.10, we define
EllipsisType = type(Ellipsis)in_typing_extra.EllipsisTypeis then used in a type expression but pyright raises an error becauseEllipsisTypeis defined as variable.Instead, we make use of the
ellipsisbuiltin, only available for type checkers (defined in typeshed) as a compatibility hack.Change Summary
Related issue number
Checklist