Skip to content

hashing support for urls #10975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2024
Merged

hashing support for urls #10975

merged 2 commits into from
Nov 25, 2024

Conversation

sydney-runkle
Copy link
Contributor

Add hash support for new url types

Fix #10955

Thanks for starting this @vivekkeshore in #10956

Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 86255b1
Status: ✅  Deploy successful!
Preview URL: https://007d8a7e.pydantic-docs.pages.dev
Branch Preview URL: https://fix-hashes.pydantic-docs.pages.dev

View logs

@sydney-runkle sydney-runkle enabled auto-merge (squash) November 25, 2024 20:55
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #10975 will not alter performance

Comparing fix-hashes (86255b1) with main (a67002a)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@sydney-runkle sydney-runkle merged commit eec33b4 into main Nov 25, 2024
53 checks passed
@sydney-runkle sydney-runkle deleted the fix-hashes branch November 25, 2024 21:01
sydney-runkle added a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In 2.10.1 the AnyHttpUrl is not hashable any more
2 participants