Deploying pydantic-docs with    Cloudflare Pages

View logs

CodSpeed Performance Report

Merging #11032 will not alter performance

_{Comparing create-model-rework (a0c253b) with main (c6905b6)}

Summary

✅ 46 untouched benchmarks

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
pydantic
main.py
Project Total

This report was generated by python-coverage-comment-action

I've added the relnotes-change label, as we should highlight the official end of support for __slots__ in the release notes here.

As you mentioned, deprecated long ago, so I'm not too worried about breakages here.

I'm look at this as I suspect this causes multiple regressions 2.10.6 -> 2.11.0 when using create_model

known to me:

• using model_config as field (easy, using config instead)
• using a property(…) as field (yet unknown)

as there is multiple issues linked to this change - any chance this gets revisited?

as there is multiple issues linked to this change - any chance this gets revisited?

As mentioned in the linked issues, this wasn't documented/expected, in particular for model_config vs __config__. This is a typical https://xkcd.com/1172/ situation, so nothing will change for 2.11. For properties, this is unfortunate but it was clearly documented that the extra keyword arguments are fields.

At the very least, we could backport the fix for #11709 in the next patch release.

Let's forget about model_config/config, inconvenient but won't cause any long lasting headaches.

For computed fields and properties, as it works for models created by inheriting from BaseModel, there is nothing wrong in the expectation create_model can do the same. And it did the same for about two years.

As an MRE for property issue:

from pydantic import create_model, ConfigDict


def mkx():
    def get_additionalProperties(x):
        return x.model_extra

    return get_additionalProperties, None, None


A = create_model(
    'A',
    __config__=ConfigDict(extra="allow"),
    aio3_additionalProperties=(None, property(mkx()[0])),
)

a = A(x=1)
assert not isinstance(a.aio3_additionalProperties, property)

A possible fix - make the annotation declaration optional:

            if f_def[0]:
                annotations[f_name] = f_def[0]
            fields[f_name] = f_def[1]
        else:
            annotations[f_name] = f_def

there is nothing wrong in the expectation create_model can do the same.

There is, as I mention and this can be seen in the 2.10 documentation:

We haven't decided on a solution yet, but it will probably not be using the **kwargs. #11709 is the issue tracking this, and the implementation will be backported to 2.11.