Add FastAPI and SQLModel to third-party tests #11044
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
ca343f7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8f6ecfb5.pydantic-docs.pages.dev |
| Branch Preview URL: | https://testing-expeirment.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11044 will not alter performanceComparing Summary
|
Coverage report
This PR does not seem to contain any modification to coverable code. |
55d2cd9 to
914f05e
Compare
b7f1c40 to
63136c7
Compare
63136c7 to
30c3aae
Compare
4dab230 to
47137b0
Compare
There was a problem hiding this comment.
Looks great, thanks!
Note, re screenshot above - not sure if we need the ticks as it doesn't display as code on the actions list or actions drilldown.
Also, before we merge this PR, could we add a section to contributing.md that explains our criteria / process for adding integration tests like this? Ex - # of starts, amount of usage, etc?
f81116c to
7bd5036
Compare
|
|
||
| - The project is actively maintained. | ||
| - Making use of Pydantic internals (e.g. relying on the [`BaseModel`][pydantic.BaseModel] metaclass, typing utilities). | ||
| - The project is popular enough (although small projects can still be included depending on how Pydantic is being used). |
There was a problem hiding this comment.
I feel like we should quantify this (some # of stars, downloads)
There was a problem hiding this comment.
The thing is it really depends on how Pydantic is used. We can have project with 100k stars but if it is only defining simple models (e.g. models for an API client, and types are well contained) then there's no interest in testing it. On the other hand, a project with 200 stars defining complex custom types is more valuable. So it is hard to quantify :/
Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
Part of #11160.