Support initializing root model fields with values of the root type in the mypy plugin
#11212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the mypy plugin Also use the `TypeInfo.has_base` method instead of iterating over the MRO in various places.
Deploying pydantic-docs with
|
| Latest commit: |
9dd8b0a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://37172f3c.pydantic-docs.pages.dev |
| Branch Preview URL: | https://root-model-plugin.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11212 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sydney-runkle
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
This LGTM overall (thanks for adding the tests, those made the impact here quite clear), but let's have @dmontagu take a look as well given his familiarity with the mypy plugin.
dmontagu
approved these changes
Jan 8, 2025
|
Hello! We have started noticing these errors: Can this change be the cause of these new error? It was working fine last week. |
|
Indeed, rolling back to 2.10.6 and this problem does not appear. So I guess this has pretty much broken our mypy checks :( |
|
@antoniogamizdelgado please open a new issue with a MRE. |
1 task
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the
TypeInfo.has_basemethod instead of iterating over the MRO in various places.Closes #11203.
Change Summary
Related issue number
Checklist