Add discriminated union related metadata entries to the CoreMetadata definition
#11216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
de894e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://760627cb.pydantic-docs.pages.dev |
| Branch Preview URL: | https://discriminated-union-meta-typ.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #11216 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
sydney-runkle
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Yep, this makes sense.
I would love to not have to apply discriminators after schema build, but I don't think we know of a great way around that for now.
This is more consistent with the metadata pattern we currently use elsewhere, at least.
Would also love to have another discussion about moving that metadata structure to pydantic-core so that we can avoid all of the internal casting...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #10655.
Change Summary
Related issue number
Checklist