Skip to content

Add documentation about removal smart_union in v2 #11275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

usernameMAI
Copy link
Contributor

@usernameMAI usernameMAI commented Jan 15, 2025

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@usernameMAI
Copy link
Contributor Author

please review

Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #11275 will not alter performance

Comparing usernameMAI:usernameMAI/add-documentation-about-removal-smart-union (b013947) with main (e7abf51)

Summary

✅ 45 untouched benchmarks

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@sydney-runkle sydney-runkle merged commit fa61ff8 into pydantic:main Jan 16, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants