Skip to content

Add support for validation_alias in the mypy plugin #11295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Add support for validation_alias in the mypy plugin #11295

merged 1 commit into from
Jan 21, 2025

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Jan 17, 2025

Change Summary

Fixes #10991

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jan 17, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 17, 2025 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9ca561c
Status: ✅  Deploy successful!
Preview URL: https://e2c143d6.pydantic-docs.pages.dev
Branch Preview URL: https://mypy-plugin-validation-alias.pydantic-docs.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11295 will not alter performance

Comparing mypy-plugin-validation-alias (9ca561c) with main (fa61ff8)

Summary

✅ 45 untouched benchmarks

@Viicos Viicos force-pushed the mypy-plugin-validation-alias branch from 84e522f to 63ef416 Compare January 17, 2025 16:33
@Viicos Viicos force-pushed the mypy-plugin-validation-alias branch from 63ef416 to 9ca561c Compare January 17, 2025 16:47
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  mypy.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos changed the title Add support for validation_alias in mypy plugin Add support for validation_alias in the mypy plugin Jan 18, 2025
sydney-runkle
sydney-runkle reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update mypy tests to use more recent versions soon?

Looks good otherwise, I left 2 comments with questions

sydney-runkle
sydney-runkle approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Viicos Viicos merged commit 42b9328 into main Jan 21, 2025
56 checks passed
@Viicos Viicos deleted the mypy-plugin-validation-alias branch January 21, 2025 17:49
This was referenced Apr 9, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pydantic-Mypy works with alias, but not with validation_alias
2 participants
@Viicos @sydney-runkle