Skip to content

Traverse function-before schemas during schema gathering #11801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Apr 28, 2025

Change Summary

Fixes #11800.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Apr 28, 2025
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b97f008
Status: ✅  Deploy successful!
Preview URL: https://1e6301e6.pydantic-docs.pages.dev
Branch Preview URL: https://gather-function-before.pydantic-docs.pages.dev

View logs

@Viicos Viicos added the backport-2.11 Needs backport to 2.11 label Apr 28, 2025
Copy link

codspeed-hq bot commented Apr 28, 2025

CodSpeed Performance Report

Merging #11801 will not alter performance

Comparing gather-function-before (b97f008) with main (7df0816)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _schema_gather.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos merged commit 5e300c3 into main Apr 29, 2025
64 checks passed
@Viicos Viicos deleted the gather-function-before branch April 29, 2025 11:33
Viicos added a commit that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.11 Needs backport to 2.11 relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Schema generation fails when before validator's json_schema_input_type set to a model that is not referenced in the class
2 participants