Schemas #190
Merged
Schemas #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 1209 1253 +44
Branches 224 232 +8
=====================================
+ Hits 1209 1253 +44 |
Closed
dsully
reviewed
Jun 11, 2018
| @@ -32,11 +32,21 @@ class Validator(NamedTuple): | |||
| check_fields: bool | |||
|
|
|||
|
|
|||
| class Schema: | |||
There was a problem hiding this comment.
Adding a docstring and/or comment would be helpful here to know what this class is for.
There was a problem hiding this comment.
will do, I need to do docs for this in general.
|
Needs docs, but otherwise think this is ready. |
|
@samuelcolvin PR looks great! When you're plan to merge and release change? |
|
Just needs docs. I'll do it soon. |
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
* starting Arguments * arguments validator WIP * working on validate_args_pair * arguments validator compiling * starting tests * WIP JSON args mapping * fix argument mapping for json * fix tests, add comment about build_args * tweaking argument errors * missing tuple args * fix tuple tests * using new errors * mapping positional arguments * fix too_long and too_short errors * linting * converting kwarg errors * improve coverage * improve coverage * add always_validate_kwargs * allow *args with zero arguments * fix extra args with args mapping * error on repeat arguments * validator decorator and more coverage * skip positional only args tests for <3.10 * fix for python <3.10 * separate build_validate_generic_mapping * Arguments, take 2 (pydantic#203) * WIP moving to lookup item for args * Arguments take 2 * adding var_args and var_kwargs handling * new arguments logic working * fixing tests * Non-default argument follows default arguments * test aliases * test kwargs * fix unexpected_positional_argument * improve coverage * PyArgs use tuple, not list * coverage and tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement #129
Sadly the syntax I has hoped to use (tuples of
default, Schema) doesn't work since tuple packing with variable type annotations turns out to be a syntax error (referenced in parsing python/typing#258) it works with parentheses but that's annoying.Instead I've moved the default declaration into the schema