Skip to content

CI: Add array_api_tests CI job #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024
Merged

CI: Add array_api_tests CI job #668

merged 1 commit into from
Apr 26, 2024

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Apr 26, 2024

Hi @hameerabbasi,

This PR adds array_api_tests CI job that runs array_api_tests/test_signatures.py test suite against Finch backend.

array-api-skips.txt file contains all currently unimplemented functions.

@mtsokol mtsokol added the enhancement Indicates new feature requests label Apr 26, 2024
@mtsokol mtsokol self-assigned this Apr 26, 2024
@hameerabbasi
Copy link
Collaborator

Is there a way to ensure that if we add new functionality, we HAVE to remove the corresponding lines from the skips file? Basically treat them as xfail and use this: scrict xfails

Copy link

github-actions bot commented Apr 26, 2024

Test Results

5 923 tests  ±0   5 891 ✅ +1   6m 52s ⏱️ - 5m 9s
    1 suites ±0      32 💤  - 1 
    1 files   ±0       0 ❌ ±0 

Results for commit 6170535. ± Comparison against base commit 0308ed0.

This pull request skips 2 and un-skips 3 tests.
sparse.numba_backend.tests.test_compressed ‑ test_reductions_float16[f4-1-sum-kwargs0]
sparse.numba_backend.tests.test_compressed ‑ test_reductions_float16[i8-None-sum-kwargs0]
sparse.numba_backend.tests.test_compressed ‑ test_reductions_float16[f8-None-sum-kwargs0]
sparse.numba_backend.tests.test_coo ‑ test_reductions_float16[i4-None-sum-kwargs0]
sparse.numba_backend.tests.test_coo ‑ test_reductions_float16[i8-None-sum-kwargs0]

♻️ This comment has been updated with latest results.

@mtsokol
Copy link
Collaborator Author

mtsokol commented Apr 26, 2024

I don't think array-api-tests supports it. Skips file just defines which functions are missing. We did it this way in NumPy and we successfully got to 99% compatibility after a few months. One needs to remember to remove specific lines from this file.

@hameerabbasi hameerabbasi merged commit 37c71c5 into main Apr 26, 2024
11 checks passed
@hameerabbasi hameerabbasi deleted the array-api-test-ci branch April 26, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants