Tests: Eliminate a bunch of redundant test files #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`xx.dot` turned out to be identical to `b102.dot`, except that the font sizes were all changed from `10` to `14`. Since that difference alone isn't really testing anything useful, we only need one of those files.
Six pairs of test files turned out to be byte-for-byte identical. Remove one of each pair.
`graphs/lsunix[123].dot` were all too similar to be useful. Same for `graphs/process.dot` and `graphs/p[234].dot`. Keep only one from each set. (The "most complex", generally.)
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
I've never ventured into those old files, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the
test/graphs/directory, I discovered that it contained:dfd.ps) that was never referenced anywhere in the repo; deleted.xx.dotandb102.dotwere identical except for the font size value of each element; deletedxx.dot.lsunix[123].dotwere wildly (and unhelpfully) similar; deletedlsunix[12].dotand renamedlsunix3.dottolsunix.dot.process.dotandp[234].dotwere also iterations of the same graph, kept only the most complex (p4.dot)