Skip to content

Query set source #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Oct 7, 2020
Merged

Query set source #230

merged 25 commits into from
Oct 7, 2020

Conversation

chfw
Copy link
Member

@chfw chfw commented Oct 7, 2020

to work with pyexcel-io v0.6.1, pyexcel/pyexcel-io#80

With your PR, here is a check list:

  • Has Test cases written
  • Has all code lines tested
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • run 'make format' so as to confirm the pyexcel organisation's coding style
  • Please add yourself to 'contributors' section of pyexcel.yml (if not found, please use CONTRIBUTORS.rst)
  • Agree on NEW BSD License for your contribution

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #230 into dev will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #230      +/-   ##
==========================================
- Coverage   98.35%   98.35%   -0.01%     
==========================================
  Files         103      103              
  Lines        6733     6732       -1     
==========================================
- Hits         6622     6621       -1     
  Misses        111      111              
Impacted Files Coverage Δ
pyexcel/book.py 98.40% <ø> (ø)
pyexcel/deprecated.py 91.48% <ø> (ø)
pyexcel/internal/meta.py 95.23% <ø> (ø)
pyexcel/internal/plugins.py 100.00% <ø> (ø)
pyexcel/internal/sheets/_shared.py 95.77% <ø> (ø)
pyexcel/internal/sheets/column.py 97.61% <ø> (ø)
pyexcel/internal/sheets/matrix.py 98.48% <ø> (ø)
pyexcel/internal/sheets/row.py 95.41% <ø> (ø)
pyexcel/plugins/sources/file_input.py 100.00% <ø> (ø)
pyexcel/plugins/sources/file_output.py 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5abaee2...9d89306. Read the comment docs.

@chfw chfw merged commit 7bcfee8 into dev Oct 7, 2020
@chfw chfw deleted the query-set-source branch October 7, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants