Skip to content

New style reader #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 2, 2020
Merged

New style reader #1

merged 7 commits into from
Oct 2, 2020

Conversation

chfw
Copy link
Member

@chfw chfw commented Oct 2, 2020 •
edited
Loading

pyexcel/pyexcel-io#80

With your PR, here is a check list:

  • Has Test cases written
  • Has all code lines tested
  • Has make format been run?
  • Has moban been run?
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • run 'make format' so as to confirm the pyexcel organisation's coding style
  • Please update CHANGELOG.rst
  • Please add yourself to CONTRIBUTORS.rst
  • Agree on NEW BSD License for your contribution

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2020 •
edited
Loading

Codecov Report

Merging #1 into dev will decrease coverage by 0.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev       #1      +/-   ##
==========================================
- Coverage   98.24%   97.67%   -0.58%     
==========================================
  Files           4        4              
  Lines         171      172       +1     
==========================================
  Hits          168      168              
- Misses          3        4       +1
Impacted Files Coverage Δ
pyexcel_htmlr/__init__.py 100.00% <100.00%> (ø)
pyexcel_htmlr/_version.py 100.00% <100.00%> (ø)
pyexcel_htmlr/htmlr.py 96.61% <100.00%> (-0.85%) ⬇️
tests/test_htmlr.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2855e37...a205f42. Read the comment docs.

@chfw chfw merged commit 8cd5f37 into dev Oct 2, 2020
@chfw chfw deleted the new-style-reader branch October 2, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfw @codecov-commenter