Skip to content

Django jump column #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2020
Merged

Django jump column #103

merged 4 commits into from
Oct 29, 2020

Conversation

chfw
Copy link
Member

@chfw chfw commented Oct 28, 2020

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

@codecov-io
Copy link

codecov-io commented Oct 29, 2020 •
edited
Loading

Codecov Report

Merging #103 into dev will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #103      +/-   ##
==========================================
+ Coverage   97.86%   97.91%   +0.04%     
==========================================
  Files          52       52              
  Lines        3332     3359      +27     
==========================================
+ Hits         3261     3289      +28     
+ Misses         71       70       -1
Impacted Files Coverage Δ
pyexcel_io/database/common.py 100.00% <100.00%> (ø)
pyexcel_io/database/importers/django.py 100.00% <100.00%> (ø)
pyexcel_io/database/importers/sqlalchemy.py 98.27% <100.00%> (+1.97%) ⬆️
tests/test_django_book.py 99.67% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ed71b...441f914. Read the comment docs.

@chfw chfw merged commit cd081dd into dev Oct 29, 2020
@chfw chfw deleted the django-jump-column branch October 31, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfw @codecov-io