Skip to content

Django plug-in Enhancement #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2020
Merged

Django plug-in Enhancement #105

merged 3 commits into from
Oct 31, 2020

Conversation

chfw
Copy link
Member

@chfw chfw commented Oct 31, 2020

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

@codecov-io
Copy link

codecov-io commented Oct 31, 2020

Codecov Report

Merging #105 into dev will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #105   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files          52       52           
  Lines        3359     3360    +1     
=======================================
+ Hits         3289     3290    +1     
  Misses         70       70           
Impacted Files Coverage Δ
pyexcel_io/database/common.py 100.00% <100.00%> (ø)
pyexcel_io/database/importers/django.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd081dd...da375cb. Read the comment docs.

@chfw chfw merged commit 783bbb5 into dev Oct 31, 2020
@chfw chfw deleted the enhancement branch October 31, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants