Skip to content

Handle zip files which contain non-UTF-8 encoded files #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2020
Merged

Handle zip files which contain non-UTF-8 encoded files #75

merged 1 commit into from
Sep 19, 2020

Conversation

craiga
Copy link
Contributor

@craiga craiga commented Sep 16, 2020 •
edited
Loading

Fixes #74

  • Has Test cases written
  • Has all code lines tested
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • run 'make format' so as to confirm the pyexcel organisation's coding style
  • Please add yourself to 'contributors' section of pyexcel-io.yml (if not found, please use CONTRIBUTORS.rst)
  • Agree on NEW BSD License for your contribution

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #75 into dev will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #75      +/-   ##
==========================================
+ Coverage   95.63%   95.64%   +0.01%     
==========================================
  Files          47       47              
  Lines        3252     3263      +11     
==========================================
+ Hits         3110     3121      +11     
  Misses        142      142
Impacted Files Coverage Δ
pyexcel_io/readers/csvz.py 100.00% <100.00%> (ø)
tests/test_new_csvz_book.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a96bdc3...61c1195. Read the comment docs.

@chfw chfw merged commit 1ee31b0 into pyexcel:dev Sep 19, 2020
@chfw
Copy link
Member

chfw commented Sep 19, 2020

thanks for your contribution! I will get it released in next release.

I have some work to refactor pyexcel-io writer to the new version. it may take some time.

chfw added a commit that referenced this pull request Sep 19, 2020
@chfw
📚 relocate change log to changelog.yml, which will be rendered into C…
e205c50 
…HANGELOG.rst. #75
chfw added a commit that referenced this pull request Sep 19, 2020
@chfw
📚 auto update(this is auto scraped from github profile) contributors …
5a22a85 
…and change log. #75
@chfw
Copy link
Member

chfw commented Sep 19, 2020

@craiga , I hope you are OK with contributor update, which is done by https://github.com/moremoban/gease/blob/dev/gease/contributors.py#L60

@craiga craiga deleted the not-utf8-csv-in-zip branch September 24, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSV inside ZIP which is not UTF-8 encoded causes UnicodeDecodeError
3 participants
@craiga @codecov-commenter @chfw