Skip to content

One reader/writer handle many file types, i.e. csv reader for csv and tsv #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 27, 2020
Merged

One reader/writer handle many file types, i.e. csv reader for csv and tsv #81

merged 5 commits into from
Sep 27, 2020

Conversation

chfw
Copy link
Member

@chfw chfw commented Sep 27, 2020

With your PR, here is a check list:

  • Has Test cases written
  • Has all code lines tested
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • run 'make format' so as to confirm the pyexcel organisation's coding style
  • Please add yourself to 'contributors' section of pyexcel-io.yml (if not found, please use CONTRIBUTORS.rst)
  • Agree on NEW BSD License for your contribution

@chfw chfw changed the title One class many file type One reader/writer handle many file types, i.e. csv reader for csv and tsv Sep 27, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2020 •
edited
Loading

Codecov Report

Merging #81 into dev will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #81   +/-   ##
=======================================
  Coverage   96.88%   96.89%           
=======================================
  Files          51       46    -5     
  Lines        3212     3189   -23     
=======================================
- Hits         3112     3090   -22     
+ Misses        100       99    -1
Impacted Files Coverage Δ
pyexcel_io/readers/__init__.py 100.00% <ø> (ø)
pyexcel_io/writers/__init__.py 100.00% <ø> (ø)
pyexcel_io/database/exporters/django.py 100.00% <100.00%> (ø)
pyexcel_io/database/exporters/sqlalchemy.py 100.00% <100.00%> (ø)
pyexcel_io/database/importers/django.py 97.95% <100.00%> (ø)
pyexcel_io/database/importers/sqlalchemy.py 95.00% <100.00%> (ø)
pyexcel_io/reader.py 97.40% <100.00%> (ø)
pyexcel_io/readers/csv_content.py 100.00% <100.00%> (ø)
pyexcel_io/readers/csv_in_file.py 100.00% <100.00%> (ø)
pyexcel_io/readers/csv_in_memory.py 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c774c...db0d772. Read the comment docs.

@chfw chfw merged commit 020b8f0 into dev Sep 27, 2020
@chfw chfw deleted the one-class-many-file-type branch October 6, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfw @codecov-commenter