Skip to content

Plugin api #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2020
Merged

Plugin api #82

merged 3 commits into from
Sep 28, 2020

Conversation

chfw
Copy link
Member

@chfw chfw commented Sep 28, 2020

With your PR, here is a check list:

  • Has Test cases written
  • Has all code lines tested
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • run 'make format' so as to confirm the pyexcel organisation's coding style
  • Please add yourself to 'contributors' section of pyexcel-io.yml (if not found, please use CONTRIBUTORS.rst)
  • Agree on NEW BSD License for your contribution

@codecov-commenter
Copy link

Codecov Report

Merging #82 into dev will increase coverage by 0.04%.
The diff coverage is 97.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #82      +/-   ##
==========================================
+ Coverage   96.89%   96.94%   +0.04%     
==========================================
  Files          46       49       +3     
  Lines        3189     3203      +14     
==========================================
+ Hits         3090     3105      +15     
+ Misses         99       98       -1
Impacted Files Coverage Δ
pyexcel_io/io.py 98.23% <0.00%> (-0.88%) ⬇️
pyexcel_io/plugin_api/abstract_writer.py 87.50% <87.50%> (ø)
pyexcel_io/database/exporters/django.py 100.00% <100.00%> (ø)
pyexcel_io/database/exporters/sqlalchemy.py 100.00% <100.00%> (ø)
pyexcel_io/database/querysets.py 94.87% <100.00%> (-0.13%) ⬇️
pyexcel_io/plugin_api/abstract_reader.py 100.00% <100.00%> (ø)
pyexcel_io/plugin_api/abstract_sheet.py 100.00% <100.00%> (ø)
pyexcel_io/readers/csv_in_file.py 100.00% <100.00%> (ø)
pyexcel_io/readers/csv_in_memory.py 100.00% <100.00%> (ø)
pyexcel_io/readers/csv_sheet.py 98.16% <100.00%> (+0.03%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020b8f0...71b27d8. Read the comment docs.

@chfw chfw merged commit d66637a into dev Sep 28, 2020
@chfw chfw deleted the plugin-api branch October 6, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfw @codecov-commenter