Skip to content

Code refinement #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 29, 2020
Merged

Code refinement #84

merged 6 commits into from
Sep 29, 2020

Conversation

chfw
Copy link
Member

@chfw chfw commented Sep 29, 2020

With your PR, here is a check list:

  • Has Test cases written
  • Has all code lines tested
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • run 'make format' so as to confirm the pyexcel organisation's coding style
  • Please add yourself to 'contributors' section of pyexcel-io.yml (if not found, please use CONTRIBUTORS.rst)
  • Agree on NEW BSD License for your contribution

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020 •
edited
Loading

Codecov Report

Merging #84 into dev will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #84      +/-   ##
==========================================
- Coverage   96.96%   96.96%   -0.01%     
==========================================
  Files          50       50              
  Lines        3226     3225       -1     
==========================================
- Hits         3128     3127       -1     
  Misses         98       98
Impacted Files Coverage Δ
pyexcel_io/_compact.py 62.96% <ø> (-1.33%) ⬇️
pyexcel_io/constants.py 100.00% <ø> (ø)
pyexcel_io/io.py 98.23% <ø> (ø)
pyexcel_io/database/__init__.py 100.00% <100.00%> (ø)
pyexcel_io/database/querysets.py 95.12% <100.00%> (ø)
pyexcel_io/plugin_api/abstract_sheet.py 100.00% <100.00%> (ø)
pyexcel_io/plugins.py 96.29% <100.00%> (ø)
pyexcel_io/readers/__init__.py 100.00% <100.00%> (ø)
pyexcel_io/readers/csv_sheet.py 98.14% <100.00%> (-0.02%) ⬇️
pyexcel_io/writers/__init__.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a2d25...84872b7. Read the comment docs.

@chfw chfw merged commit 13ee5d6 into dev Sep 29, 2020
@chfw chfw deleted the code-refinement branch September 29, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfw @codecov-commenter