Skip to content

Sheet writer interface #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 30, 2020
Merged

Sheet writer interface #87

merged 8 commits into from
Sep 30, 2020

Conversation

chfw
Copy link
Member

@chfw chfw commented Sep 30, 2020

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020 •
edited
Loading

Codecov Report

Merging #87 into dev will increase coverage by 0.00%.
The diff coverage is 95.65%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #87   +/-   ##
=======================================
  Coverage   97.02%   97.02%           
=======================================
  Files          50       50           
  Lines        3222     3225    +3     
=======================================
+ Hits         3126     3129    +3     
  Misses         96       96
Impacted Files Coverage Δ
pyexcel_io/database/importers/sqlalchemy.py 96.36% <85.71%> (+0.06%) ⬆️
pyexcel_io/database/importers/django.py 100.00% <100.00%> (ø)
pyexcel_io/plugin_api/abstract_sheet.py 100.00% <100.00%> (ø)
pyexcel_io/writers/csv_sheet.py 100.00% <100.00%> (ø)
pyexcel_io/writers/csvz_sheet.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ba606...c86927d. Read the comment docs.

@chfw chfw merged commit efcf49c into dev Sep 30, 2020
@chfw chfw deleted the sheet-writer-interface branch September 30, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfw @codecov-commenter