Json serialisation #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds many tests for html, json, and rst. Notes many errors for json. Update JsonSheetWriter to order JSON keys for reproducible file output checks.
The JSON format raise a TypeError when serializing either a generator and NominableSheet. Convert them to types that the json package can serialise, and support column and row names.
|
Thanks. I got the basis of my objective completed using this. See I'll be doing some analysis of the resulting data over the next few days, and unless they are bugs it would be nice to have this released. |
|
Let me fix #8 and get a release out of it and you could then update https://github.com/jayvdb/era_data/blob/master/requirements.txt#L3 |
|
There is also a FIXME i added to the tests, but i am out of time until the weekend |
|
ready to be released. let me know after you will have time to evaluate 0.1.2. |
|
A changelog file would be helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.