Skip to content

[Backport maintenance/3.3.x] Improve backport job permissions #10391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented May 18, 2025

Backport 222ab20 from #10390.

Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (5fce790) to head (f30c749).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           maintenance/3.3.x   #10391   +/-   ##
==================================================
  Coverage              95.84%   95.84%           
==================================================
  Files                    174      174           
  Lines                  18995    18995           
==================================================
  Hits                   18206    18206           
  Misses                   789      789           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible, no more close/open to do 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit 5addaaa into maintenance/3.3.x May 18, 2025
23 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-10390-to-maintenance/3.3.x branch May 18, 2025 11:09
@cdce8p
Copy link
Member Author

cdce8p commented May 18, 2025

Incredible, no more close/open to do 😄

Seems I missed on detail 😅 All backport PRs are created in my name since I own the PAT. Maybe we should have a bot for it.

@Pierre-Sassoulas
Copy link
Member

Before that it was "github-actions / bot " (#10315)

@cdce8p
Copy link
Member Author

cdce8p commented May 18, 2025

Before that it was "github-actions / bot " (#10315)

Yeah. With PAT we need an owner for it though.

@cdce8p
Copy link
Member Author

cdce8p commented May 18, 2025

Just created the pylint-dev-bot let's hope everything still works 🤞🏻

@Pierre-Sassoulas
Copy link
Member

Nice, thank you !

Pierre-Sassoulas added a commit that referenced this pull request Aug 9, 2025
…10487)

* [ci] Install pylint before every test (#10388) (#10389)

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>

* Improve backport job permissions (#10390) (#10391)

(cherry picked from commit 222ab20)

* Resolve `possibly-used-before-assignment` false positives from `match` block assignments (#10393)

(cherry picked from commit ad14b5b)

* Use custom Github App to authenticate backport job (#10394) (#10396)

(cherry picked from commit 6be8676)

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>

* Fix Pyreverse: Aggregations aren't filtered according to filter mode (PUB_ONLY, etc.) (#10379) (#10401)

* updated diagrams.py file

* added tests

* updated tests

* added test cases

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------


(cherry picked from commit ed59632)

Co-authored-by: pavan-msys <149513767+pavan-msys@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Fix Mermaid printer rendering double underscores as bold formatting (#10403) (#10410)

(cherry picked from commit 25a0f9e)

Co-authored-by: Julian Grimm <51880314+Julfried@users.noreply.github.com>
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>

* Respect docstring-min-length in docparams extension (#10104) (#10434)

(cherry picked from commit 7f5e996)

Co-authored-by: Berker ŞAL <brkr.sal@gmail.com>

* Fix `unused-variable` false positive when using same name for multiple exceptions (#10436) (#10481)

(cherry picked from commit 9e72867)

Co-authored-by: Zen Lee <53538590+zenlyj@users.noreply.github.com>

* Fix false-negative for used-before-assignment with postponed evaluation in function defs (#10482) (#10483)

(cherry picked from commit d363fca)

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>

* Update pytest-benchmark requirement from ~=4.0 to ~=5.1 (#10066) (#10484)

(cherry picked from commit f04761b)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pylint to 3.3.8, update changelog (#10486)

---------

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Co-authored-by: pylint-backport-bot[bot] <212256041+pylint-backport-bot[bot]@users.noreply.github.com>
Co-authored-by: pavan-msys <149513767+pavan-msys@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Julian Grimm <51880314+Julfried@users.noreply.github.com>
Co-authored-by: Berker ŞAL <brkr.sal@gmail.com>
Co-authored-by: Zen Lee <53538590+zenlyj@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants