Fix release_notes_to_discourse script
#7862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error 400 was caused by not passing json explicitly.
ricardoV94
commented
Jul 22, 2025
| @@ -64,7 +64,7 @@ def format_release_content(config: dict[str, str]) -> tuple[str, str]: | |||
|
|
|||
| - **Version:** `{config["RELEASE_TAG"]}` | |||
| - **Repository:** [{config["REPO_NAME"]}](https://github.com/{config["REPO_NAME"]}) | |||
| - **Release Page:** [View on GitHub]({config["RELEASE_URL"]}) | |||
| - **Release Page:** {config["RELEASE_URL"]} | |||
There was a problem hiding this comment.
I didn't like the View on Github, no reason to lose info from a readable URL like this
release_notes_to_discourse script
twiecki
reviewed
Jul 22, 2025
| @@ -105,7 +105,7 @@ def publish_release_to_discourse(config: dict[str, str]) -> bool: | |||
| url = f"{config['DISCOURSE_URL']}/posts.json" | |||
|
|
|||
| try: | |||
| response = requests.post(url, headers=headers, data=topic_data) | |||
| response = requests.post(url, headers=headers, json=topic_data) | |||
twiecki
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed here: https://github.com/pymc-devs/pymc/actions/runs/16454405920/job/46507668592
Now that I could recreate the inputs passed by github I could reproduce locally, and confirm the change to
jsonfixes it: https://discourse.pymc.io/t/release-v5-25-0/17206📚 Documentation preview 📚: https://pymc--7862.org.readthedocs.build/en/7862/