Skip to content

simplify pre-commit and jupytext settings #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2022
Merged

simplify pre-commit and jupytext settings #483

merged 2 commits into from
Dec 27, 2022

Conversation

OriolAbril
Copy link
Member

Attempt to simplify pre-commit and jupytext config.

This now treats the ipynb as the only source of truth, converting it
to myst when committing. It also removes codespell which ran on myst
files and complicated the whole syncing loop.

@OriolAbril OriolAbril mentioned this pull request Dec 24, 2022
Closed
@twiecki
Copy link
Member

twiecki commented Dec 27, 2022 

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/pymc-examples/envs/483/lib/python3.8/site-packages/sphinx_codeautolink/extension/block.py", line 211, in parse_source
    names = parse_names(modified_source, node)
  File "/home/docs/checkouts/readthedocs.org/user_builds/pymc-examples/envs/483/lib/python3.8/site-packages/sphinx_codeautolink/parse.py", line 21, in parse_names
    tree = ast.parse(source)
  File "/home/docs/.pyenv/versions/3.8.6/lib/python3.8/ast.py", line 47, in parse
    return compile(source, filename, mode, flags,
  File "<unknown>", line 61
    %load_ext watermark
    ^
SyntaxError: invalid syntax

@twiecki twiecki merged commit dd0b2b8 into pymc-devs:main Dec 27, 2022
@twiecki twiecki mentioned this pull request Dec 27, 2022
Closed
@OriolAbril OriolAbril deleted the pre-commit branch December 27, 2022 13:50
@twiecki
Copy link
Member

twiecki commented Dec 27, 2022

Had a chance to test it and it works much better 👌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiecki twiecki twiecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OriolAbril @twiecki