only mark disconnection in mark_disconnect #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ramiro plz C |
|
travis fails to test in PR from fork =( |
| Free resources used by this object. | ||
| """ | ||
| log("_mssql.MSSQLConnection.real_close()") | ||
| if self in connection_object_list: |
There was a problem hiding this comment.
Wouln't be safer to use connection_object_list.remove(self) and catch+ignore ValueError?
There was a problem hiding this comment.
Yep, that would be. Wasn't sure how cython hadles exceptions and stuff. Just like python?
There was a problem hiding this comment.
Yes, it's a def method so any Python construct is fair game.
(I've tested it and Cython builds it withour errors). See also http://docs.cython.org/src/userguide/language_basics.html#python-functions-vs-c-functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406