Simpler fix for __new__ with copy.copy() #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
==========================================
- Coverage 89.67% 89.46% -0.21%
==========================================
Files 11 11
Lines 4028 4026 -2
Branches 1013 1013
==========================================
- Hits 3612 3602 -10
- Misses 217 224 +7
- Partials 199 200 +1
Continue to review full report at Codecov.
|
|
Ok, we'll give it a shot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered something more straightforward than what I had in #413 to fix the interactions between
copy.copy()and a customized__new__. (For info about the__getnewargs__method, see the pickle module.)