Skip to content

Kill previous worker if another eval/execute is asked to the donkey #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WebReflection opened this issue Oct 8, 2024 · 0 comments · Fixed by #2218
Closed

Kill previous worker if another eval/execute is asked to the donkey #2214

WebReflection opened this issue Oct 8, 2024 · 0 comments · Fixed by #2218
Assignees
Labels
type: bug Something isn't working type: feature New feature or request

Comments

@WebReflection
Copy link
Contributor

WebReflection commented Oct 8, 2024

What happened?

A donkey executes/evals code which could have infinite loop but it doesn't necessarily stop the donkey from accepting new code to execute/evaluate.

Currently, because the donkey uses a shared interpreter, the next execution/evaluation cannot happen because the donkey is stuck fulfilling the previous task.

We should be smart about infinite loops or code stuck and be able to kill the previous worker behind the scene and start a new one when repeated execute/eval are demanded, otherwise the whole use case would be stuck forever.

Users have a chance to opt-in for awaiting each donkey execution/evaluation, but that shouldn't be mandatory and, if it is, there's no way to get out that awaiting state from the code.

What browsers are you seeing the problem on? (if applicable)

No response

Console info

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: feature New feature or request
Projects
None yet
1 participant