Skip to content

Hotfix for py-script/py-repl loading #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2022

Conversation

fpliger
Copy link
Contributor

@fpliger fpliger commented May 3, 2022

This replaces using the interpreter promise with using the interpreter itself. Also make it event base instead of relying on delays. This is not a global fix and we still need to fix elsewhere but the rest can come in a follow up PR

@fpliger fpliger added status: ready PR that is ready for review tag: interpreter Related to the Python interpreter configuration labels May 3, 2022
@fpliger fpliger requested a review from philippjfr May 3, 2022 14:15
@pzwang
Copy link

pzwang commented May 3, 2022

The repl/antigravity and TODO app examples work for me!

@fpliger
Copy link
Contributor Author

fpliger commented May 3, 2022

Merging it to have a faster turnaround on a few bugs. If reviews come back later I can put a follow up PR.

@fpliger fpliger merged commit 70d4014 into main May 3, 2022
@fpliger fpliger deleted the quickfix/pyscript_loading_sequence branch May 3, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR that is ready for review tag: interpreter Related to the Python interpreter configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants