remove pyscriptjs and synclink #1787
Conversation
There was a problem hiding this comment.
Please check what we're doing WRT latest.
Love all the red for deleting old cruft. Bravo @madhur-tandon
| @@ -11,8 +11,7 @@ | |||
| rel="stylesheet" | |||
| href="https://pyscript.net/latest/pyscript.css" | |||
| /> | |||
| <script defer src="../../pyscriptjs/build/pyscript.js"></script> | |||
| <!-- <script defer src="https://pyscript.net/latest/pyscript.js"></script> --> | |||
| <script defer src="https://pyscript.net/latest/pyscript.js"></script> | |||
There was a problem hiding this comment.
We're retiring latest right..? This should be a versioned link..?
There was a problem hiding this comment.
So, many examples have the same link i.e. https://pyscript.net/latest/pyscript.js
You can checkout the antigravity.html in the examples folder in the current state of the repository here: https://github.com/pyscript/pyscript/blob/main/examples/antigravity.html#L11
I guess we can address everything related to examples in a separate / follow-up PR?
The purpose of this specific change was to at least make things consistent, even if they are wrong and are to be cleaned up eventually...
There was a problem hiding this comment.
Ack. OK. We definitely need to get the examples story straight. For the record (and reflecting the conversation with @antocuni on Slack this morning):
- Examples will be removed from this repository.
- They will have their own versioned repository (tracking the PyScript version).
- The examples will be synced with versions on PyScript.com
- We're retiring
latestand the examples will be pinned to specific versions of PyScript.
Right?
There was a problem hiding this comment.
yes, we should stop using /latest.
Whether we want to actually remove the URL is an open question, but it's probably good to discuss it elsewhere
|
I love this PR but I think it helps from development point of view having classic around as reference. It's true that we have already a branch with classic stuff (or do we?) but switching branches while developing is not really a smooth experience ... long story short: are we sure it's during RC development that we want or even need to remove all legacy related stuff? Otherwise, LGTM too. |
|
@WebReflection we definitely have a classic branch, and if we can't trust |
it's not about not trusting git, it's about having ongoing changes you don't want to commit just to look at something classic did before ... you change branch? you can't ... you need to stash then change then back then pop stash and this is friction I rather don't want to have myself but also I can create a separate folder that points at legacy branch and call it a day so ... feel free to ignore my comment and let's merge this! |
|
So long PyScript Classic!🚀 |
|
Let's go! Thank you @madhur-tandon ! |
Description
Removes the old
pyscriptjsdirectory that contained synclink related stuff.Checklist