Allow PyScript to fully run locally #1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyscript.core/src/toml.js
Outdated
| @@ -0,0 +1,4 @@ | |||
| // https://cdn.jsdelivr.net/npm/@webreflection/toml-j0.4/toml.js | |||
There was a problem hiding this comment.
Is there value in noting the specific release of toml-j0.4 here, just in case we (you) ever do an update/release of that project and we want to be able to tell which version is included here? 1.1.3 it lookslike?
There was a problem hiding this comment.
AFAIK nobody is planning to maintain or change that project so I might indeed jut create yet another automated artifact that grabs that from latest version (expected to be always the same) and place it in the src folder before building it.
Or maybe I can just add it as npm dependency and still automate that process ... this actually might be the best way to go:
- the version is embedded in the package.json
- the automation simply reflects that
Good hint!
JeffersGlass
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As @fpliger currently spotted, it's harder than it should to run PyScript project offline because we reach the CDN for the optional toml parser.
This MR moves that file locally so that we can use the
distfolder to load on demand that library as opposite of needing the CDN.Changes
pyscript.core/src/folderdistfolderChecklist
docs/changelog.md