Skip to content

Add playwright to dependency installation steps. #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2023
Merged

Add playwright to dependency installation steps. #1852

merged 2 commits into from
Nov 8, 2023

Conversation

ntoll
Copy link
Member

@ntoll ntoll commented Nov 8, 2023

Description

Playwright is needed for running the test suite during the build of the new version of PyScript. This PR ensures playwright is installed.

Changes

Ensure playwright is installed in: prepare-release.yml, publish-release.yml and publish-unstable.yml

Checklist

  • All tests pass locally
  • I have updated docs/changelog.md
  • I have created documentation for this(if applicable)

WebReflection
WebReflection approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@WebReflection WebReflection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ntoll ntoll merged commit ab15ac3 into main Nov 8, 2023
@ntoll ntoll deleted the ntoll-publish branch November 8, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebReflection WebReflection WebReflection approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntoll @WebReflection