Skip to content

Reduce conflicts on multiple custom scripts #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2023
Merged

Reduce conflicts on multiple custom scripts #1897

merged 1 commit into from
Dec 14, 2023

Conversation

WebReflection
Copy link
Contributor

Description

This MR fixes an issue when both mpy and py scripts (or related tags) live on the same page / main thread + it reduces possible conflicts around the currentScript exposed via our own module.

Changes

  • move within the for loop all variables that should not be shared among interpreters
  • test that everything actually works as expected
  • fix typo in PyWorker description

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

fpliger
fpliger approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻 lgtm!

@WebReflection WebReflection merged commit 136e954 into pyscript:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpliger fpliger fpliger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebReflection @fpliger