Adding __terminal__ reference on terminal scripts #1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntoll
approved these changes
Jan 22, 2024
hoodmane
reviewed
Jan 22, 2024
Comment on lines
+146
to
+154
|
|
||
| // on main, it's easy to trash and clean the current terminal | ||
| globalThis.__py_terminal__ = init({ | ||
| disableStdin: true, | ||
| cursorBlink: false, | ||
| cursorStyle: "underline", | ||
| }); | ||
| run("from js import __py_terminal__ as __terminal__"); | ||
| delete globalThis.__py_terminal__; |
There was a problem hiding this comment.
You still ought to be able to assign to the Python scope directly from JavaScript rather than doing this globalThis dance...
There was a problem hiding this comment.
agreed, I am not proud of that ugly dance but it worked well in both MicroPython and Pyodide ... can I do better for both "worlds"? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR fixes in a more robust and elegant way #1923 by providing a "dunder terminal" reference out of the box that points at the currently running Xterm instance and as discussed, and agreed, with both @JeffersGlass and @ntoll.
Changes
polyscript.currentScriptonly when it's robust and reliable to set the__terminal__reference once in workers__terminal__through its reference in mainChecklist
CHANGELOG.md