Update package.json and package-lock.json
#204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fpliger this PR actually contained two commits and I did not upgrade any dependencies.
We could definitely roll back 1 but I think 2 is worth doing. Also, re: 1 I'm not sure what the guidance is for committing lockfiles anyway for JS libraries (as opposed to apps). In Python, I generally wouldn't store the lock file in the repo for a library, but that is up for discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
npm installusingnpm v18.0.0, I was greeted with these warnings:The lockfile was updated.
I also noticed the name and version were incorrect in
package.json. I made an assumption on the version number, but knew1.0.0was definitely not correct.