Skip to content

Added listeners to the constructing kw options #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

Added listeners to the constructing kw options #2044

merged 1 commit into from
May 3, 2024

Conversation

WebReflection
Copy link
Contributor

Description

This MR adds a feature to pass onopen, onmessage, onerror and onclose listeners directly to the web socket once it gets initialized.

Changes

  • optionally accepts onopen, onmessage, onerror and onclose as kw arguments and directly set this while initializing the web socket
  • test everything is fine

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

@WebReflection WebReflection merged commit c49cb92 into pyscript:main May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

+1 more reviewer

@FabioRosado FabioRosado FabioRosado approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WebReflection @ntoll @FabioRosado