Skip to content

fix: broken methods video.snap and canvas.download #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

mchilvers
Copy link
Contributor

Description

video.snap and canvas.download methods used an obsolete method (self.create). They don't anymore.

Changes

Replace use of create with call to the appropriate Element instance e.g. self/create("canvas") -> canvas())

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

@mchilvers mchilvers merged commit f20a000 into main Jul 23, 2024
2 checks passed
@mchilvers mchilvers deleted the mc/fix-video-snap-canvas-download branch July 23, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants