Skip to content

Implemented pyminify for our stdlib #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

WebReflection
Copy link
Contributor

Description

This MR hooks into our build process python-minifier so that all files are reduced in term of size and bundle needed to be bootstrapped on the vFS.

Changes

  • added requirements to install and run pyminify
  • tested that everything is right
  • added escape hatch via NO_MIN=1 env variable to be able to avoid Python minification

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WebReflection WebReflection force-pushed the minify branch 3 times, most recently from c4549ac to 7b25905 Compare August 7, 2024 08:55
@WebReflection
Copy link
Contributor Author

@ntoll this has been published as https://cdn.jsdelivr.net/npm/@pyscript/core@0.5.5/dist/core.js on npm

@WebReflection WebReflection merged commit f4c4ede into pyscript:main Aug 7, 2024
2 checks passed
WebReflection added a commit to WebReflection/pyscript that referenced this pull request Aug 7, 2024
* Implemented pyminify for our stdlib

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
WebReflection added a commit to WebReflection/pyscript that referenced this pull request Aug 7, 2024
* Implemented pyminify for our stdlib

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants