-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix #2114 - Cleanup the test folder + automation #2143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9645124
to
67f5fe7
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... we have test
and tests
. 🤣
@ntoll that's always been the case ... but tests has only Python content in it and it's everything but trivial to test for real with a browser ... to be honest I consider that folder for Python tests or Python code while everything running on the front end as JS should imho be easy to verify and check. I wouldn't mind renaming either folder to make things a bit more clear ... such as |
@ntoll to be honest, there is a lot going on in the tests folder and it's fully handled by |
@ntoll OK ... I've merged everything into |
8207c06
to
b5506aa
Compare
Works for me. |
b5506aa
to
83d6af6
Compare
not for CI though ... the error in pyscript_dom is super weird ... I have tested manually and everything looks fine? maybe we had some test relying on that |
9973d16
to
26b05c0
Compare
FYI ... a classic example on why I prefer real browsers and folders with real Web code in there and nothing else ... the |
8d3e18c
to
3021798
Compare
3021798
to
a73f7bc
Compare
OK, I think this is fine now ... it should pass. Basically in pytest we were trusting and using the |
Description
This MR reorganized tests currently present in our
test
andtests
folder + it creates automatically atests/index.html
page that makes it easier to manually test things around.A lot of tests require manual or visual verification and I didn't bother removing those handy one-off pages which I do, in fact, use pretty often to validate or check things.
I hope this initial cleanup would help us in the present/future to keep the test folder clean and well organized, by also trying to not create single
.html
files and put everything in folders when necessary.Changes
tests/index.html
creation like it's done in polyscripttests/
foldertest/integration
intotests/js-integration
and updated tests using thetest
reference in pytest to use now directlytests
insteadChecklist
CHANGELOG.md