Fix #2146 - Workaround Pyodide issue with attributes #2148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ecd677 to
ecc248c
Compare
|
This version of PyScript has been published already on npm as |
hoodmane
reviewed
Aug 26, 2024
| for t in ["onclose", "onerror", "onmessage", "onopen"]: | ||
| if t in kw: | ||
| socket[t] = kw[t] | ||
| # Pyodide fails at setting socket[t] directly | ||
| set_attr(socket, t, create_proxy(kw[t])) |
There was a problem hiding this comment.
Python has a builtin called setattr that does this:
Suggested change
| set_attr(socket, t, create_proxy(kw[t])) | |
| setattr(socket, t, create_proxy(kw[t])) |
There was a problem hiding this comment.
silly me ... thanks, fixed that! why wouldn't that accessor be set though? MicroPython had no issue with socket[t] = kw[t] but Pyodide threw an error before due "unable to set property X" issue 🤔
we are good with setattr but it's a bit of a worry/need to remember thing I haven't witnessed before.
for more information, see https://pre-commit.ci
ecc248c to
355a453
Compare
FabioRosado
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2146
Fixes #2145
It looks like Pyodide has issues with "magic" JS accessors such as
onmessageand others exposed by WebSocket instances /cc @hoodmaneChanges
create_proxyto ensure no errors once these callbacks are invokedtests/ws/andbun index.jsafter changingmpytopyChecklist
CHANGELOG.md