Fix #2150 - Avoid trashing previous added elements #2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9dde46 to
2a9b1a1
Compare
|
FYI I am trying to figure out if this was covered, just to be sure I am using/reaching the right primitive there ... if that's confirmed, I think we should be good to merge this /cc @mchilvers |
|
@ntoll by any chance you can confirm this is good to go? it'd be great to have for our next release, thanks! |
ntoll
approved these changes
Sep 10, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR fixes #2150 by using element.insertAdjacentHTML so that previously appended elements don't lose their reference.
Changes
appendChildinstead ofappendfor elements, asappendis slower due checks on arguments type and it brings no benefits thereinsertAdjacentHTMLinstead ofinnerHTML += '...'as latter would replace all previously appended children each time it's usedQuestion
@mchilvers what's the intent there?
appendalready works with text but here it looks like we wanted to accept HTML and not just text, if this is correct then this MR should improve a lot the current state, thanks.Checklist
CHANGELOG.md