Skip to content

Improve by far error reporting around PyEditor bootstrap #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

WebReflection
Copy link
Contributor

Description

This MR goal is to inform users when their editors fail due one of these conditions:

  • the config points to a non existent file
  • the config fails to be parsed
  • the src points to a non existent file

Changes

  • wraps around try/catch all the cases where users defined files are relevant
  • use the error notifier to show errors on the page right away
  • test manually everything is actually fine

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

@WebReflection WebReflection requested a review from ntoll September 3, 2024 12:25
@WebReflection
Copy link
Contributor Author

layout from the added test file:

Screenshot from 2024-09-03 14-32-06

@WebReflection WebReflection merged commit 7b9f7c1 into pyscript:main Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants