Skip to content

Fix #2156 - Test @when with async listener #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix #2156 - Test @when with async listener #2157

merged 1 commit into from
Sep 6, 2024

Conversation

WebReflection
Copy link
Contributor

Description

This MR fixes #2156 by simply providing a test case for an async listener added via @when.

Changes

  • added an example of async listener added via @when decorator
  • tested everything is fine

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

@WebReflection WebReflection requested a review from ntoll September 6, 2024 08:02
@WebReflection WebReflection merged commit e525d54 into pyscript:main Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebReflection @ntoll