Avoid throwing if Pyodide does not await due missing arguments #2158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0bd1953 to
f923602
Compare
8bb46be to
a65e9fc
Compare
for more information, see https://pre-commit.ci
ntoll
approved these changes
Sep 6, 2024
| def wrapper(*args, **kwargs): | ||
| func() | ||
| # Function is async: must be awaited | ||
| if inspect.iscoroutinefunction(func): |
There was a problem hiding this comment.
Interestingly, this bit of code only ever runs in Pyodide (see the ugly hack comment elsewhere in this function).
There was a problem hiding this comment.
Yeah, it's Pyodide only that has issues when no args are passed indeed and MicroPython doesn't need any of this and it works out of the box 🤷
There was a problem hiding this comment.
just in case, it was literally in this MR description:
In Pyodide (only) use case when a function has no args but it's async, the wrapper is not asynchronous and it doesn't await the passed callback. This results into hard to understand errors otherwise not present in MicroPython.
😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Pyodide (only) use case when a function has no args but it's
async, thewrapperis not asynchronous and it doesn't await the passed callback. This results into hard to understand errors otherwise not present in MicroPython.This MR fixes that by using the right introspection to decide how the wrapper should be defined (that is: either async or sync).
Changes
asyncwrapper when the given function is async tooasync def click()andasync def click(event)after@whendef click()anddef click(event)after@whenChecklist
CHANGELOG.md