Fix #2167 - Provide instructions to build the project #2168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntoll
approved these changes
Sep 13, 2024
WebReflection
added a commit
to pyscript/polyscript
that referenced
this pull request
Sep 13, 2024
WebReflection
commented
Sep 13, 2024
pyscript.core/rollup/stdlib.cjs
Outdated
| @@ -42,7 +42,8 @@ const crawl = (path, json) => { | |||
| pip install --ignore-requires-python python-minifier | |||
| pip install setuptools | |||
| \x1b[2mand you can then try \x1b[0mnpm run build\x1b[2m again.\x1b[0m | |||
| `)); | |||
| `), | |||
There was a problem hiding this comment.
this is ugly prettier ... very ugly ...
067f91b to
124886e
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR fixes #2167 by providing visual and meaningful instructions on how to build the project.
Changes
try/catcharound the build intentnpm run buildcommand won't fail againChecklist
CHANGELOG.md