Exposing config type once resolved and running #2175
Conversation
9cf193b to
b11e011
Compare
b11e011 to
71c6cda
Compare
| @@ -10,6 +10,11 @@ | |||
|
|
|||
| config = json.loads(globalThis.JSON.stringify(_config)) | |||
|
|
|||
| if "MicroPython" in sys.version: | |||
There was a problem hiding this comment.
I usually normalise to: if "micropython" in sys.version.lower() But I don't think it makes much difference.
There was a problem hiding this comment.
I believe they really want the MicroPython brand to be MicroPython but I don't mind applying that change ... alternatively I could use other try/catches or pass the type from the page but that is actually pretty convoluted due workers VS main VS config in PyScript VS Polyscript and so on ... I think this was the fastest and easy way around.
There was a problem hiding this comment.
Yeah... it's also the smallest possible change. We can refine later if there are problems / feature requests. Was just mentioning it as a sort of "out of interest..." point. 👍
|
Also, apologies, I thought I had marked this as approved when I first commented. My bad. |
Description
This MR fixes #2174 by exposing a
typein the already handyconfigwe provide.Changes
config["type"]Checklist
CHANGELOG.md