Fix #2185 - Updated Polyscript and coincident #2187
Conversation
98bf849 to
5bc23cb
Compare
5bc23cb to
93c6bbf
Compare
| pre-commit==3.7.1 | ||
| playwright==1.44.0 |
There was a problem hiding this comment.
We'll need playwright installed to run the test suite locally, right..?
There was a problem hiding this comment.
it's installed via npx playwright install chromium which is already part of the build process in CI.
I don't mind keeping that in if that's how you get it but it's redundant (see our Makefile)
There was a problem hiding this comment.
|
@ntoll I am going to merge this and, after that, whenever you have time, please pull latest from main and confirm you can run a build without issues 'cause even CI has been happy so far but one time had a timeout and I am not sure if it has anything to do with latest changes. I still believe I should dedicate more time in coincident to actually make it better for any sort of more-convoluted scenario where GC form other worlds might mess up things. |
|
@WebReflection just confirming that I created a brand new Python venv, pulled latest from main, did a setup as if a fresh install, and then ran a build. All tests pass. One gremlin: |
Description
This MR fixes #2185 via latest Polyscript and coincident.
I also took a chance to cleanup our CI workflow as there were tons of things not needed anymore.
Changes
Checklist
CHANGELOG.md