Skip to content

Indirect refs counting #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

WebReflection
Copy link
Contributor

Description

Turns out, I had somehow already embedded "ref counting" inside the logic because each Worker gets its own worker/main relation so that all I had to do was to move from a shared heap across all workers to a dedicated heap per each worker.

Changes

  • reverted globals retention in coincident
  • updated js-proxy/heap to provide a way to create a unique heap
  • created a new heap per each worker so that there won't be conflicts between workers at all
  • updated polyscript to use latest coincident
  • tested multiple times everything works as expected

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable)

@WebReflection WebReflection requested a review from ntoll September 27, 2024 13:00
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WebReflection WebReflection merged commit ad2af23 into pyscript:main Sep 27, 2024
2 checks passed
@WebReflection
Copy link
Contributor Author

This latest version of PyScript has been published on npm as @pyscript/core@0.5.15:

  • JS https://cdn.jsdelivr.net/npm/@pyscript/core@0.5.15/dist/core.js
  • CSS https://cdn.jsdelivr.net/npm/@pyscript/core@0.5.15/dist/core.css

CI never even tried to fail this time and I am pretty confident latest changes behind the scene were the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants