Skip to content

Updated coincident to use a local channel #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

WebReflection
Copy link
Contributor

Description

This MR moved the only final bit shared across coincident Workers which was the crypto.generateUUID() call shared among workers (but it didn't have to be shared).

This MR updates coincident via latest polyscript in an attempt to be sure none of our CI fails anymore, hence using again all available workers instead of limiting these to just 1.

Changes

  • updated polyscript with latest coincident
  • removed --workers=1 while testing

Checklist

  • All tests pass locally
  • I have created / updated documentation for this (if applicable)

@WebReflection WebReflection requested a review from ntoll September 30, 2024 11:21
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WebReflection WebReflection force-pushed the local-channel branch 4 times, most recently from d77aae0 to e3b86a9 Compare September 30, 2024 11:57
@WebReflection WebReflection merged commit 8de97a7 into pyscript:main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants