Skip to content

Add a "donkey" worker that execs or evaluates all the things #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

WebReflection
Copy link
Contributor

@WebReflection WebReflection commented Oct 4, 2024

Description

This MR brings in a new lazy-loaded utility currently called donkey to bootstrap a worker terminal that executes or evaluates code on demand ... it's been super-welcomed by Educational related projects and I think it's a super-handy extra feature we could offer out of the box.

Changes

  • provide a lazy-loaded (no final PyScript size corrupted) utility to bootstrap a terminal that can be driven directly via JS

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

@WebReflection WebReflection changed the title WIP WIP - Add a "donkey" worker that execs or evaluates all the things Oct 4, 2024
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏 🫏

@ntoll
Copy link
Member

ntoll commented Oct 4, 2024

I love the name. A donkey (🫏 ) is cute, determined and a hard worker. This is a wonderfully playful metaphor. 🤣 🫏 🫏 🫏 🫏

@WebReflection WebReflection marked this pull request as ready for review October 4, 2024 14:58
@WebReflection WebReflection changed the title WIP - Add a "donkey" worker that execs or evaluates all the things Add a "donkey" worker that execs or evaluates all the things Oct 4, 2024
@WebReflection WebReflection merged commit f827efe into pyscript:main Oct 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants